Add null check to wolfSSL_Free #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please |
dgarske
previously approved these changes
May 15, 2024
|
@embhorn please resolve new conflicts. @JacobBarthelmeh please merge when you are happy with PR. |
|
retest this please |
JacobBarthelmeh
approved these changes
May 16, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Add null check to wolfSSL_Free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If wolfSSL_Free() determines that the ‘heap’ argument is not NULL, it goes on to the ‘else’ statement of memory.c, where it executes the following: 'wc_LockMutex(&(mem->memory_mutex)’ without checking whether ‘mem’ (AKA hint->memory) is NULL.
Fixes zd17779
Testing
Customer confirmed
Checklist